Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom badge to ipfs pages #8234

Merged
merged 1 commit into from
Mar 18, 2021
Merged

Add custom badge to ipfs pages #8234

merged 1 commit into from
Mar 18, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Mar 12, 2021 •
edited
Loading

Resolves brave/brave-browser#13172

image

  • Added custom badge that will be shown only if we show an icon from page and no secure text available to show, otherwise standard chromium flow will be shown.
  • Forked default PageInfo bubble, since we have not yet decided what to show there left the current content

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@spylogsster spylogsster requested a review from bbondy March 12, 2021 15:27
@spylogsster spylogsster requested a review from a team as a code owner March 12, 2021 15:27
@spylogsster spylogsster force-pushed the ipfs-page-indicator branch 2 times, most recently from 106ad84 to ccb495c Compare March 12, 2021 15:56
@spylogsster spylogsster changed the title Add custom badge to ipfs pages Add custom badge to ipfs pages (prototype, not for merge) Mar 12, 2021
mkarolin
mkarolin approved these changes Mar 12, 2021
View reviewed changes
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ on chromium_src and patches

@spylogsster spylogsster changed the title Add custom badge to ipfs pages (prototype, not for merge) Add custom badge to ipfs pages Mar 12, 2021
@spylogsster spylogsster force-pushed the ipfs-page-indicator branch 2 times, most recently from ccb495c to e65256b Compare March 12, 2021 18:50
@spylogsster spylogsster mentioned this pull request Mar 12, 2021
Closed
@diracdeltas
Copy link
Member

the icon looks cut off in macos

Screen Shot 2021-03-15 at 1 50 51 PM

@spylogsster spylogsster force-pushed the ipfs-page-indicator branch 2 times, most recently from 2b91639 to 14af562 Compare March 16, 2021 17:14
@spylogsster
Copy link
Contributor Author

the icon looks cut off in macos

Screen Shot 2021-03-15 at 1 50 51 PM

image

fixed

bbondy
bbondy requested changes Mar 18, 2021
View reviewed changes
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good when you use it. But I think we should not fork files.

browser/ui/views/ipfs/ipfs_info_bubble_view.cc Outdated Show resolved Hide resolved
@spylogsster spylogsster force-pushed the ipfs-page-indicator branch 3 times, most recently from d4767c1 to 48448e6 Compare March 18, 2021 14:57
@spylogsster spylogsster merged commit 5bdae03 into master Mar 18, 2021
@spylogsster spylogsster deleted the ipfs-page-indicator branch March 18, 2021 20:37
@spylogsster spylogsster added this to the 1.24.x - Nightly milestone Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkarolin mkarolin mkarolin approved these changes

@bbondy bbondy bbondy approved these changes

Assignees

@spylogsster spylogsster

Labels
None yet
Projects
None yet
Milestone
1.24.x - Release
Development

Successfully merging this pull request may close these issues.

Add a "Brave page" like indicator for IPFS schemes
4 participants
@spylogsster @diracdeltas @bbondy @mkarolin